Fix & reuse printing of dummyTreeOfType #16750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main fix is the unsplice, which was making the pattern not match for FunProto. But also, when the tree is applied to the dummy, print the dummy in the Apply node. And print null as a constant literal. Also, given AnyFunctionProto and AnyTypeConstructorProto shorter toStrings.
dwijnand
force-pushed
the
fix-printing-dummyTreeOfType
branch
from
38b9fd8 to
94ff3c8
Compare
odersky
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main fix is the unsplice, which was making the pattern not match for
FunProto. But also, when the tree is applied to the dummy, print the
dummy in the Apply node. And print null as a constant literal.
Also, given AnyFunctionProto and AnyTypeConstructorProto shorter
toStrings.